Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the emulation is cleared #583

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Ensure the emulation is cleared #583

merged 2 commits into from
Oct 16, 2019

Conversation

fairlane
Copy link
Contributor

@fairlane fairlane commented Oct 16, 2019 •
edited
Loading

Clear the emulation in finally block in the abstract indexer.

Motivation and Context

If the indexing blows up the environment emulation was not necessarily cleared.

How Has This Been Tested?

Tested locally by running the indexers.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@fairlane fairlane added this to the 4.0.0-RC2 milestone Oct 16, 2019
@fairlane fairlane self-assigned this Oct 16, 2019
@fairlane fairlane merged commit 47d9a14 into feature/product-caching-index Oct 16, 2019
@fairlane fairlane deleted the enhancement/ensure-the-emulation-is-cleared branch October 16, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supercid supercid supercid approved these changes

@mridang mridang mridang approved these changes

@olsi-qose olsi-qose Awaiting requested review from olsi-qose

Assignees

@fairlane fairlane

Labels
enhancement
Projects
None yet
Milestone
4.0.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@fairlane @mridang @supercid