Merge pull request #753 from Nosto/hotfix/5.3.2

Improve NonBuildableProductException
Nosto · Nov 16, 2021 · fa21980 · fa21980
2 parents 032553a + 0f08468
commit fa21980
Show file tree

Hide file tree

Showing 5 changed files with 585 additions and 429 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 5.3.2
+* Improve exception during product build by passing previos exception
+
 ### 5.3.1
 * Fix to use placeholder thumbnail image if product has no image
 

diff --git a/Model/Product/Builder.php b/Model/Product/Builder.php
@@ -313,7 +313,8 @@ public function build(
                 )->getCode()
             );
         } catch (Exception $e) {
-            throw new NonBuildableProductException($e->getMessage());
+            $message = sprintf("Could not build product with id: %s", $product->getId());
+            throw new NonBuildableProductException($message, $e);
         }
         $this->eventManager->dispatch(
             'nosto_product_load_after',

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
   "name": "nosto/module-nostotagging",
   "description": "Increase your conversion rate and average order value by delivering your customers personalized product recommendations throughout their shopping journey.",
   "type": "magento2-module",
-  "version": "5.3.1",
+  "version": "5.3.2",
   "require-dev": {
     "phpmd/phpmd": "^2.5",
     "sebastian/phpcpd": "*",
@@ -38,7 +38,7 @@
     "OSL-3.0"
   ],
   "require": {
-    "nosto/php-sdk": ">=5.3.7",
+    "nosto/php-sdk": ">=5.4.1",
     "php": ">=7.0.0",
     "magento/framework": ">=101.0.6|~102.0",
     "ext-json": "*"