Cleanup deadcode

Nosto · Feb 17, 2025 · a658a56 · a658a56
1 parent 57fb34e
commit a658a56
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 74 deletions.
diff --git a/Model/Category/Repository.php b/Model/Category/Repository.php
@@ -37,12 +37,6 @@
 namespace Nosto\Tagging\Model\Category;
 
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Catalog\Model\CategoryRepository;
-use Magento\Catalog\Model\ResourceModel\Category\Collection as CategoryCollection;
-use Magento\Framework\Api\SearchCriteriaBuilder;
-use Magento\Framework\Exception\LocalizedException;
-use Magento\Store\Model\Store;
-use Magento\Catalog\Model\ResourceModel\Category\CollectionFactory as CategoryCollectionFactory;
 use Nosto\Tagging\Exception\ParentCategoryDisabledException;
 
 /**
@@ -52,43 +46,6 @@ class Repository
 {
     private array $parentCategoryIdCache = [];
 
-    /** @var SearchCriteriaBuilder $searchCriteriaBuilder */
-    private SearchCriteriaBuilder $searchCriteriaBuilder;
-
-    /** @var CategoryRepository $categoryRepository */
-    private CategoryRepository $categoryRepository;
-
-    /** @var CategoryCollectionFactory $categoryCollectionFactory */
-    private CategoryCollectionFactory $categoryCollectionFactory;
-
-    /**
-     * @param SearchCriteriaBuilder $searchCriteriaBuilder
-     */
-    public function __construct(
-        SearchCriteriaBuilder $searchCriteriaBuilder,
-        CategoryRepository $categoryRepository,
-        CategoryCollectionFactory $categoryCollectionFactory
-    ) {
-        $this->searchCriteriaBuilder = $searchCriteriaBuilder;
-        $this->categoryRepository = $categoryRepository;
-        $this->categoryCollectionFactory = $categoryCollectionFactory;
-    }
-
-    /**
-     * Gets categories by category ids
-     *
-     * @param array $ids
-     * @return mixed
-     */
-    public function getByIds(array $ids)
-    {
-        $searchCriteria = $this->searchCriteriaBuilder
-            ->addFilter('entity_id', $ids, 'in')
-            ->create();
-        /** @noinspection PhpUndefinedMethodInspection */
-        return $this->categoryRepository->getList($searchCriteria);
-    }
-
     /**
      *  Gets the parent category ID's for a given category
      *
@@ -121,31 +78,6 @@ public function resolveParentCategoryIds(CategoryInterface $category): ?array
         return $parentCategoryIds;
     }
 
-    /**
-     * @param Store $store
-     * @param array $categoryIds
-     *
-     * @return CategoryCollection
-     * @throws LocalizedException
-     */
-    public function getCategoryCollectionQuery(Store $store, array $categoryIds = [])
-    {
-        $categories = $this->categoryCollectionFactory->create()
-            ->distinct(true)
-            ->addNameToResult()
-            ->setStoreId($store->getId())
-            ->addUrlRewriteToResult()
-            ->addAttributeToFilter('level', ['gt' => 1])
-            ->addAttributeToSelect(array_merge(['name', 'is_active', 'include_in_menu']))
-            ->addOrderField('entity_id');
-
-        if ($categoryIds) {
-            $categories->addAttributeToFilter('entity_id', ['in' => $categoryIds]);
-        }
-
-        return $categories;
-    }
-
     /**
      * Get Parent Category IDS
      *
@@ -181,5 +113,4 @@ private function saveParentIdsToCache(CategoryInterface $category, array $parent
     {
         $this->parentCategoryIdCache[$category->getId()] = $parentCategoryIds;
     }
-
 }
diff --git a/Model/Service/Sync/AbstractBulkPublisher.php b/Model/Service/Sync/AbstractBulkPublisher.php
@@ -126,6 +126,7 @@ private function publishCollectionToMessageQueue(
         }
 
         $bulkUuid = $this->identityService->generateId();
+        /** @phan-suppress-next-line PhanTypeMismatchArgumentProbablyReal */
         $bulkDescription = __('Sync ' . count($entityIds) . ' Nosto entities');
         $operations = $this->generateOperationsChunks($entityIds, $storeId, $bulkUuid);
 

diff --git a/Model/Service/Sync/Upsert/Category/SyncService.php b/Model/Service/Sync/Upsert/Category/SyncService.php
@@ -114,10 +114,20 @@ public function sync(CategoryCollection $collection, Store $store)
             $this->checkMemoryConsumption('category sync');
             foreach ($page as $category) {
                 // @TODO: Adjust on the SDK to batch instead of calling the API for each category
-                $nostoCategory = $this->categoryBuilder->build($category, $store);
-                $op = new CategoryUpdate($nostoCategory, $account, $this->nostoHelperUrl->getActiveDomain($store));
-                $op->setResponseTimeout($this->apiTimeout);
-                $op->execute();
+                try {
+                    $nostoCategory = $this->categoryBuilder->build($category, $store);
+                    $op = new CategoryUpdate($nostoCategory, $account, $this->nostoHelperUrl->getActiveDomain($store));
+                    $op->setResponseTimeout($this->apiTimeout);
+                    $op->execute();
+                } catch (Exception $e) {
+                    $this->getLogger()->error(
+                        sprintf(
+                            'Failed to sync category with id %s - %s',
+                            $category->getId(),
+                            $e->getMessage()
+                        )
+                    );
+                }
             }
             $this->logDebugWithStore(
                 sprintf(

diff --git a/Observer/Order/Save.php b/Observer/Order/Save.php
@@ -46,7 +46,6 @@
 use Magento\Framework\Module\Manager as ModuleManager;
 use Magento\Sales\Model\Order;
 use Magento\Store\Model\Store;
-use Nosto\Model\Order\Buyer;
 use Nosto\Model\Order\Order as NostoOrder;
 use Nosto\Operation\Order\OrderCreate as NostoOrderCreate;
 use Nosto\Operation\Order\OrderStatus as NostoOrderUpdate;