Merge pull request #758 from Nosto/release/5.4.0

Release 5.4.0

.github/workflows/action.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Set up PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.3'
+        php-version: '7.4'
         tools: composer
         extensions: ast, bcmath, gd
         coverage: none
@@ -68,7 +68,7 @@ jobs:
     - name: Set up PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.3'
+        php-version: '7.4'
         tools: composer
         extensions: ast, bcmath, gd
         coverage: none
@@ -119,7 +119,7 @@ jobs:
     - name: Set up PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.3'
+        php-version: '7.4'
         tools: composer:v2, pecl
         extensions: ast, bcmath, gd
         coverage: none

.github/workflows/ide.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.3'
+        php-version: '7.4'
         tools: composer:v2, pecl
         extensions: bcmath, gd, pdo_mysql, zip, soap, ast
         coverage: none

.github/workflows/phan.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up PHP
       uses: shivammathur/setup-php@v2
       with:
-        php-version: '7.3'
+        php-version: '7.4'
         tools: composer:v2, pecl
         coverage: none
         extensions: ast, bcmath, gd, pdo_mysql, zip, soap

CHANGELOG.md

@@ -1,5 +1,10 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 5.4.0
+* Add functionality to send disabled products to Nosto
+* Add ttl for nosto_product_cache
+* Refactor BuilderTrait into service classes
+
 ### 5.3.2
 * Improve exception during product build by passing previos exception
 

Controller/Export/Base.php

@@ -50,6 +50,8 @@
 /**
  * Export base controller that all export controllers must extend.
  */
+// @phan-suppress-next-next-line PhanDeprecatedClass - recommended to avoid code migration till 2.5.0
+// https://community.magento.com/t5/Magento-DevBlog/Decomposition-of-Magento-Controllers/ba-p/430883
 abstract class Base extends Action
 {
     const ID = 'id';

Controller/Frontend/Cart.php

@@ -57,7 +57,8 @@
 /*
  * Controller class for handling cart restoration
  */
-
+// @phan-suppress-next-next-line PhanDeprecatedClass - recommended to avoid code migration till 2.5.0
+// https://community.magento.com/t5/Magento-DevBlog/Decomposition-of-Magento-Controllers/ba-p/430883
 class Cart extends Action
 {
     /**

Controller/Oauth/Index.php

@@ -54,6 +54,8 @@
 use Nosto\Tagging\Model\Meta\Oauth\Builder as NostoOauthBuilder;
 use Nosto\Types\Signup\AccountInterface;
 
+// @phan-suppress-next-next-line PhanDeprecatedClass - recommended to avoid code migration till 2.5.0
+// https://community.magento.com/t5/Magento-DevBlog/Decomposition-of-Magento-Controllers/ba-p/430883
 class Index extends Action
 {
     use OauthTrait;
@@ -156,7 +158,7 @@ public function save(AccountInterface $account)
             ) {
                 throw new NostoException(
                     sprintf(
-                        'This account is already being used by "%s". 
+                        'This account is already being used by "%s".
                                 Please create a new account for each store view',
                         $store->getName()
                     )

Helper/Data.php

@@ -134,6 +134,11 @@ class Data extends AbstractHelper
      */
     const XML_PATH_INDEXER_MEMORY = 'nosto/flags/indexer_memory';
 
+    /**
+     * Path to the configuration object that stores the preference for indexing disabled products
+     */
+    const XML_PATH_INDEX_DISABLED_PRODUCTS = 'nosto/flags/indexer_disabled_products';
+
     /*
      * Path to the configuration object for tagging the date a product has beed added to Magento's catalog
      */
@@ -460,6 +465,17 @@ public function getIndexerMemory(StoreInterface $store = null)
         return $this->getStoreConfig(self::XML_PATH_INDEXER_MEMORY, $store);
     }
 
+    /**
+     * Returns maximum percentage of PHP available memory that indexer should use
+     *
+     * @param StoreInterface|null $store the store model or null.
+     * @return bool the configuration value
+     */
+    public function canIndexDisabledProducts(StoreInterface $store = null)
+    {
+        return $this->getStoreConfig(self::XML_PATH_INDEX_DISABLED_PRODUCTS, $store);
+    }
+
     /**
      * Returns on/off setting for tagging product's date published
      *

Model/Email/Repository.php

@@ -66,6 +66,7 @@ public function __construct(
      */
     public function getNewsletterOptInForEmail($email)
     {
+        // @phan-suppress-next-line PhanDeprecatedFunction
         return $this->subscriber->loadByEmail($email);
     }
 

Model/Indexer/QueueIndexer.php

@@ -184,7 +184,7 @@ public function getCollection(Store $store, array $ids = []): ProductCollection
         if (!empty($ids)) {
             $this->productCollectionBuilder->withIds($ids);
         } else {
-            $this->productCollectionBuilder->withDefaultVisibility();
+            $this->productCollectionBuilder->withDefaultVisibility($store);
         }
         return $this->productCollectionBuilder->build();
     }