Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/1.2.1 - Fix array to string conversion in Sortby plugin #54

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Hotfix/1.2.1 - Fix array to string conversion in Sortby plugin #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.

### 1.2.1
* Fix bug related to Nosto sorting option in admin category page

### 1.2.0
* Add tagging for module version
* Add fragment to product urls served by CMP
Expand Down
2 changes: 1 addition & 1 deletion Plugin/Catalog/Model/Sortby.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public function afterGetAllOptions( // phpcs:ignore Generic.CodeAnalysis.UnusedF
) {
// new option
$customOption = [
['label' => __(['Relevance']), 'value' => NostoHelperSorting::NOSTO_PERSONALIZED_KEY]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not caught by Phan?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, need to look further into that

['label' => __('Relevance'), 'value' => NostoHelperSorting::NOSTO_PERSONALIZED_KEY]
];

// merge default sorting options with custom options
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nosto/module-nostocmp",
"description": "Nosto Category Merchandising extension for Magento 2",
"type": "magento2-module",
"version": "1.2.0",
"version": "1.2.1",
"require-dev": {
"php": ">=7.1.0",
"magento-ecg/coding-standard": "3.*",
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<!--suppress XmlUnboundNsPrefix -->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Nosto_Cmp" setup_version="1.2.0">
<module name="Nosto_Cmp" setup_version="1.2.1">
<sequence>
<module name="Nosto_Tagging"/>
</sequence>
Expand Down