Merge pull request #456 from Nosto/hotfix/enterprise-parent-product-l…

…oad-permission Fix saving simple product that has parent in a website without permission for the current user
Nosto · Nov 16, 2018 · 6b224e2 · 6b224e2
2 parents e56a9e2 + c4b12b3
commit 6b224e2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 3.7.6
+* Fix an issue in Magento Enterprise that would prevent to save a simple product if the logged user does not have permission to see the parent product.
+
 ### 3.7.5
 * Handle line items without concrete product in order confirmation
 * Fix price variation when customer group variation has zero price

diff --git a/app/code/community/Nosto/Tagging/Util/Product.php b/app/code/community/Nosto/Tagging/Util/Product.php
@@ -64,6 +64,8 @@ public static function buildParentProducts(Mage_Catalog_Model_Product $product)
      * product in array if no other parents were found.
      *
      * @param Mage_Catalog_Model_Product $product
+     * @suppress PhanUndeclaredClassInstanceof
+     * @suppress PhanTypeMismatchArgument
      * @return array
      */
     public static function toParentProducts(Mage_Catalog_Model_Product $product)
@@ -75,8 +77,14 @@ public static function toParentProducts(Mage_Catalog_Model_Product $product)
             $parentIds = $model->getParentIdsByChild($product->getId());
             if (!empty($parentIds)) {
                 foreach ($parentIds as $productId) {
-                    $configurable = Mage::getModel('catalog/product')->load($productId);
-                    $parents[] = $configurable;
+                    try {
+                        $configurable = Mage::getModel('catalog/product')->load($productId);
+                        $parents[] = $configurable;
+                    } catch (\Exception $e) {
+                        if ($e instanceof \Enterprise_AdminGws_Controller_Exception) {
+                            Nosto_Tagging_Helper_Log::exception($e);
+                        }
+                    }
                 }
             }
         }

diff --git a/app/code/community/Nosto/Tagging/etc/config.xml b/app/code/community/Nosto/Tagging/etc/config.xml
@@ -28,7 +28,7 @@
 <config>
     <modules>
         <Nosto_Tagging>
-            <version>3.7.5</version>
+            <version>3.7.6</version>
         </Nosto_Tagging>
     </modules>
     <global>