changes made for fix-278 #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solomonsolomonsolomon
requested changes
Jan 29, 2025
There was a problem hiding this comment.
remove node modules
|
done |
Solomonsolomonsolomon
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Looks good! However, can you break it into smaller components to improve modularity and reusability?
There was a problem hiding this comment.
revert changes here
Solomonsolomonsolomon
requested changes
Jan 30, 2025
There was a problem hiding this comment.
remove node modules
There was a problem hiding this comment.
revert changes
|
@covenantebube you can check the workflow checks for whats wrong |
|
i have resolved the issue, pls check. It can now build |
|
@covenantebube if you examine the workflow log, you can see build still fails and why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Information
Related Issues
Closes #278
Type of Change
Checklist (select as many as applicable)