Skip to content

Commit

Permalink
Skip flaky tests for linkerd#613 (linkerd#614)
Browse files Browse the repository at this point in the history
The metrics endpoint tests are flaky because there are no guarantees
that the metrics pipeline has processed events before the metrics
endpoint is read. This can cause CI to fail spuriously.

Disable these tests from running in CI until linkerd#613 is resolved.
  • Loading branch information
olix0r authored Mar 25, 2018
1 parent 7012c5f commit 8b619b9
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions proxy/tests/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ macro_rules! assert_contains {
}
}

// https://github.com/runconduit/conduit/issues/613
#[test]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn metrics_endpoint_inbound_request_count() {
let _ = env_logger::try_init();

Expand Down Expand Up @@ -295,7 +297,9 @@ fn metrics_endpoint_inbound_request_count() {

}

// https://github.com/runconduit/conduit/issues/613
#[test]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn metrics_endpoint_outbound_request_count() {
let _ = env_logger::try_init();

Expand Down Expand Up @@ -502,7 +506,9 @@ fn metrics_endpoint_outbound_response_latency() {
"response_latency_ms_count{authority=\"tele.test.svc.cluster.local\",direction=\"outbound\",status_code=\"200\"} 4");
}

// https://github.com/runconduit/conduit/issues/613
#[test]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn metrics_endpoint_inbound_request_duration() {
let _ = env_logger::try_init();

Expand Down Expand Up @@ -537,7 +543,9 @@ fn metrics_endpoint_inbound_request_duration() {
"request_duration_ms_count{authority=\"tele.test.svc.cluster.local\",direction=\"inbound\"} 2");
}

// https://github.com/runconduit/conduit/issues/613
#[test]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn metrics_endpoint_outbound_request_duration() {
let _ = env_logger::try_init();

Expand Down

0 comments on commit 8b619b9

Please sign in to comment.