Skip to content

Commit

Permalink
Introducing option to disable log coloring
Browse files Browse the repository at this point in the history 
NSM issue: networkservicemesh#1594

Signed-off-by: Botond Szirtes <[email protected]>
  • Loading branch information
@bszirtes
bszirtes committed Mar 18, 2024
1 parent b1a3e26 commit 307a9c8
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 58 deletions.
16 changes: 8 additions & 8 deletions pkg/networkservice/core/trace/traceconcise/common_test.go
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023 Cisco and/or its affiliates.
// Copyright (c) 2024 Cisco and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down Expand Up @@ -59,14 +59,14 @@ func TestOutput(t *testing.T) {
require.NotNil(t, e)

expectedOutput :=
"\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-request={\"connection\":" +
" [INFO] [id:conn-1] [type:networkService] server-request={\"connection\":" +
"{\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}},\"mechanism_preferences\":" +
"[{\"cls\":\"LOCAL\",\"type\":\"KERNEL\"},{\"cls\":\"LOCAL\",\"type\":\"KERNEL\",\"parameters\":{\"label\":\"v2\"}}]}" +
"\n\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-request-response={\"id\":\"conn-1\",\"context\":" +
"\n [INFO] [id:conn-1] [type:networkService] server-request-response={\"id\":\"conn-1\",\"context\":" +
"{\"ip_context\":{\"src_ip_required\":true}},\"labels\":{\"Label\":\"B\"}}" +
"\n\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-close={\"id\":\"conn-1\",\"context\":{\"ip_context\":" +
"\n [INFO] [id:conn-1] [type:networkService] server-close={\"id\":\"conn-1\",\"context\":{\"ip_context\":" +
"{\"src_ip_required\":true}},\"labels\":{\"Label\":\"D\"}}" +
"\n\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-close-response={\"id\":\"conn-1\",\"context\":" +
"\n [INFO] [id:conn-1] [type:networkService] server-close-response={\"id\":\"conn-1\",\"context\":" +
"{\"ip_context\":{\"src_ip_required\":true}},\"labels\":{\"Label\":\"X\"}}\n"

result := testutil.TrimLogTime(&buff)
Expand Down Expand Up @@ -99,12 +99,12 @@ func TestErrorOutput(t *testing.T) {
require.Nil(t, conn)

expectedOutput :=
"\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-request={\"connection\":" +
" [INFO] [id:conn-1] [type:networkService] server-request={\"connection\":" +
"{\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}},\"mechanism_preferences\":" +
"[{\"cls\":\"LOCAL\",\"type\":\"KERNEL\"},{\"cls\":\"LOCAL\",\"type\":\"KERNEL\",\"parameters\":{\"label\":\"v2\"}}]}\n" +
"\x1b[36m [INFO] [id:conn-1] [type:networkService] \x1b[0mserver-request-response={\"id\":\"conn-1\",\"context\":" +
" [INFO] [id:conn-1] [type:networkService] server-request-response={\"id\":\"conn-1\",\"context\":" +
"{\"ip_context\":{\"src_ip_required\":true}},\"labels\":{\"Label\":\"B\"}}\n" +
"\x1b[31m [ERRO] [id:conn-1] [type:networkService] \x1b[0mError returned from sdk/pkg/networkservice/core/trace/testutil/ErrorServer.Request:" +
" [ERRO] [id:conn-1] [type:networkService] Error returned from sdk/pkg/networkservice/core/trace/testutil/ErrorServer.Request:" +
" Error returned from api/pkg/api/networkservice/networkServiceClient.Close;" +
"\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;" +
"\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;" +
Expand Down
58 changes: 29 additions & 29 deletions pkg/networkservice/core/trace/traceverbose/common_test.go
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright (c) 2020-2023 Cisco Systems, Inc.
// Copyright (c) 2020-2024 Cisco Systems, Inc.
//
// Copyright (c) 2021-2023 Doc.ai and/or its affiliates.
// Copyright (c) 2021-2024 Doc.ai and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down Expand Up @@ -129,28 +129,28 @@ func TestTraceOutput(t *testing.T) {
require.NotNil(t, e)

expectedOutput :=
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Request()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.1) request={\"connection\":{\"id\":\"conn-1\",\"context\":" +
" [TRAC] [id:conn-1] [type:networkService] (1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Request()\n" +
" [TRAC] [id:conn-1] [type:networkService] (1.1) request={\"connection\":{\"id\":\"conn-1\",\"context\":" +
"{\"ip_context\":{\"src_ip_required\":true}}},\"mechanism_preferences\":[{\"cls\":\"LOCAL\"," +
"\"type\":\"KERNEL\"},{\"cls\":\"LOCAL\",\"type\":\"KERNEL\",\"parameters\":{\"label\"" +
":\"v2\"}}]}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.2) request-diff={\"connection\":{\"labels\":{\"+Label\":\"A\"}}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Request()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.1) request-diff={\"connection\":{\"labels\":{\"Label\":\"B\"}}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.2) request-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}," +
" [TRAC] [id:conn-1] [type:networkService] (1.2) request-diff={\"connection\":{\"labels\":{\"+Label\":\"A\"}}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Request()\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.1) request-diff={\"connection\":{\"labels\":{\"Label\":\"B\"}}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.2) request-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}," +
"\"labels\":{\"Label\":\"B\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.3) request-response-diff={\"labels\":{\"Label\":\"C\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.3) request-response-diff={\"labels\":{\"Label\":\"D\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Close()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.1) close={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}," +
" [TRAC] [id:conn-1] [type:networkService] (2.3) request-response-diff={\"labels\":{\"Label\":\"C\"}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (1.3) request-response-diff={\"labels\":{\"Label\":\"D\"}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Close()\n" +
" [TRAC] [id:conn-1] [type:networkService] (1.1) close={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}}," +
"\"labels\":{\"Label\":\"D\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.2) close-diff={\"labels\":{\"Label\":\"W\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Close()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.1) close-diff={\"labels\":{\"Label\":\"X\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.2) close-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\"" +
" [TRAC] [id:conn-1] [type:networkService] (1.2) close-diff={\"labels\":{\"Label\":\"W\"}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Close()\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.1) close-diff={\"labels\":{\"Label\":\"X\"}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.2) close-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\"" +
":true}},\"labels\":{\"Label\":\"X\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.3) close-response-diff={\"labels\":{\"Label\":\"Y\"}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.3) close-response-diff={\"labels\":{\"Label\":\"Z\"}}\n"
" [TRAC] [id:conn-1] [type:networkService] (2.3) close-response-diff={\"labels\":{\"Label\":\"Y\"}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (1.3) close-response-diff={\"labels\":{\"Label\":\"Z\"}}\n"

result := testutil.TrimLogTime(&buff)
require.Equal(t, expectedOutput, result)
Expand Down Expand Up @@ -181,20 +181,20 @@ func TestErrorOutput(t *testing.T) {
require.Nil(t, conn)

expectedOutput :=
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Request()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.1) request={\"connection\":{\"id\":\"conn-1\",\"context\":" +
" [TRAC] [id:conn-1] [type:networkService] (1) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerFirstServer.Request()\n" +
" [TRAC] [id:conn-1] [type:networkService] (1.1) request={\"connection\":{\"id\":\"conn-1\",\"context\":" +
"{\"ip_context\":{\"src_ip_required\":true}}},\"mechanism_preferences\":[{\"cls\":\"LOCAL\"," +
"\"type\":\"KERNEL\"},{\"cls\":\"LOCAL\",\"type\":\"KERNEL\",\"parameters\":{\"label\"" +
":\"v2\"}}]}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(1.2) request-diff={\"connection\":{\"labels\":{\"+Label\":\"A\"}}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Request()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.1) request-diff={\"connection\":{\"labels\":{\"Label\":\"B\"}}}\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(3) ⎆ sdk/pkg/networkservice/core/trace/testutil/ErrorServer.Request()\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(3.1) request-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}},\"labels\":{\"Label\":\"B\"}}\n" +
"\x1b[31m [ERRO] [id:conn-1] [type:networkService] \x1b[0m(3.2) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n" +
"\x1b[37m [TRAC] [id:conn-1] [type:networkService] \x1b[0m(2.2) request-response-diff={\"context\":{\"ip_context\":{\"src_ip_required\":false}},\"id\":\"\",\"labels\":{\"-Label\":\"B\"}}\n" +
"\x1b[31m [ERRO] [id:conn-1] [type:networkService] \x1b[0m(2.3) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n" +
"\x1b[31m [ERRO] [id:conn-1] [type:networkService] \x1b[0m(1.3) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n"
" [TRAC] [id:conn-1] [type:networkService] (1.2) request-diff={\"connection\":{\"labels\":{\"+Label\":\"A\"}}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (2) ⎆ sdk/pkg/networkservice/core/trace/testutil/LabelChangerSecondServer.Request()\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.1) request-diff={\"connection\":{\"labels\":{\"Label\":\"B\"}}}\n" +
" [TRAC] [id:conn-1] [type:networkService] (3) ⎆ sdk/pkg/networkservice/core/trace/testutil/ErrorServer.Request()\n" +
" [TRAC] [id:conn-1] [type:networkService] (3.1) request-response={\"id\":\"conn-1\",\"context\":{\"ip_context\":{\"src_ip_required\":true}},\"labels\":{\"Label\":\"B\"}}\n" +
" [ERRO] [id:conn-1] [type:networkService] (3.2) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n" +
" [TRAC] [id:conn-1] [type:networkService] (2.2) request-response-diff={\"context\":{\"ip_context\":{\"src_ip_required\":false}},\"id\":\"\",\"labels\":{\"-Label\":\"B\"}}\n" +
" [ERRO] [id:conn-1] [type:networkService] (2.3) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n" +
" [ERRO] [id:conn-1] [type:networkService] (1.3) Error returned from api/pkg/api/networkservice/networkServiceClient.Close;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*beginTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:85;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/trace.(*endTraceClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/trace/client.go:106;\tgithub.aaakk.us.kg/networkservicemesh/sdk/pkg/networkservice/core/next.(*nextClient).Close;\t\t/root/go/pkg/mod/github.com/networkservicemesh/[email protected]/pkg/networkservice/core/next/client.go:65;\t\n"

result := testutil.TrimLogTime(&buff)
require.Equal(t, expectedOutput, result)
Expand Down
Loading

0 comments on commit 307a9c8

Please sign in to comment.