This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Revert PR 349 #389
Merged
Revert PR 349 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenr
previously approved these changes
Sep 28, 2022
ghost
reviewed
Sep 28, 2022
ghost
reviewed
Sep 28, 2022
nordicsemi/dfu/package.py
Outdated
Comment on lines
191
to
192
| # before the `self.add_firmware_info` is called can lead to customers potentially | ||
| # bricking their devices. There may be configurations that avoid the |
There was a problem hiding this comment.
Suggested change
| # before the `self.add_firmware_info` is called can lead to customers potentially | |
| # bricking their devices. There may be configurations that avoid the | |
| # before the `self.add_firmware_info` call for HexType.EXTERNAL_APPLICATION can lead to customers potentially | |
| # bricking their devices when updating the external app. There may be configurations that avoid the |
Co-authored-by: Martin Galvan <[email protected]>
Co-authored-by: Martin Galvan <[email protected]>
Co-authored-by: Martin Galvan <[email protected]>
ghost
previously approved these changes
Sep 28, 2022
nordicsemi/dfu/package.py
Outdated
| # softdevice. Moving the setting of the `REQUIRED_SOFTDEVICES_ARRAY` | ||
| # field to be `sd_req` to before the `self__.add_firmware_info` call | ||
| # for HexType.EXTERNAL_APPLICATION can lead customers potentially | ||
| # bricking their devices. There may be configurations that avoid the |
There was a problem hiding this comment.
I'd explicitly say "bricking their devices when trying to update the app software", to emphasize that it's ok to use a 0 sd_req for bootloader and softdevice changes (assuming it actually is, of course).
kenr
previously approved these changes
Sep 28, 2022
…n an even bigger issue.
kenr
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting PR 349 caused a critical issue, resulting in a critical issue when --sd-req is 0x00.
This PR is a hotfix that simply reverts the changes of that PR.