nrfx_ncft: Add callback for RXFRAMESTART event #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When first using nrfx_ncft directly, I found it odd that while I had subscribed to NRFX_NFCT_EVT_RX_FRAMESTART, that event wasn't being raised like the others I was subscribed to. I've added a check in nrfx_nfct_irq_handler to raise that callback when NRFX_NFCT_EVT_ACTIVE(RXFRAMESTART). As nrfx_ncft doesn't need to process/handle anything else there, the only other thing it does is clears the event flag.
|
|
grochu
suggested changes
Dec 22, 2020
|
Apologies on the whitespace here too; same issue I had in #79 🙂 |
|
Closing in lieu of #97! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When first using nrfx_ncft directly, I found it odd that while I had subscribed to NRFX_NFCT_EVT_RX_FRAMESTART, that event wasn't being raised like the others I was subscribed to. I've added a check in nrfx_nfct_irq_handler to raise that callback when NRFX_NFCT_EVT_ACTIVE(RXFRAMESTART). As nrfx_ncft doesn't need to process/handle anything else there, the only other thing it does is clears the event flag.