Add Wi-Fi permission #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philips77
requested changes
Jun 11, 2024
permissions-wifi/build.gradle.kts
Outdated
|
|
||
| nordicNexusPublishing { | ||
| POM_ARTIFACT_ID = "permissions-nfc" | ||
| POM_NAME = "Nordic library for checking required nfc permission." |
There was a problem hiding this comment.
This should be: ...for checking permissions required for scanning for Wi-Fi networks.
permissions-wifi/build.gradle.kts
Outdated
| group = "no.nordicsemi.android.common" | ||
|
|
||
| nordicNexusPublishing { | ||
| POM_ARTIFACT_ID = "permissions-nfc" |
| import no.nordicsemi.android.common.theme.NordicTheme | ||
| import no.nordicsemi.android.common.theme.view.WarningView | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.TIRAMISU) |
There was a problem hiding this comment.
Why that's from Tiramisu?
| @@ -60,3 +60,4 @@ include(":permissions-ble") | |||
| include(":permissions-internet") | |||
| include(":permissions-nfc") | |||
| include(":data") | |||
| include(":permissions-wifi") | |||
There was a problem hiding this comment.
Could you put it one line up, so that permissions are together?
| <string name="wifi_disabled_des">Wi-Fi is disabled. Please enable Wi-Fi to scan for Wi-Fi networks.</string> | ||
| <string name="enable_wifi">Enable Wi-Fi</string> | ||
| <string name="wifi_not_available">WI-FI NOT AVAILABLE</string> | ||
| <string name="wifi_not_available_des">Wi-Fi is not available on this device. We won\'t be able to provision the device.</string> |
There was a problem hiding this comment.
This is a generic library, not related to provisioning.
I think it's enough to keep only the first sentence:
Wi-Fi is not available in this device.
philips77
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.