Skip to content

Commit

Permalink
Merge pull request #57 from NordicPlayground/mock_fix
Browse files Browse the repository at this point in the history
Mock fix
  • Loading branch information
sylwester-zielinski authored Jul 7, 2023
2 parents 2c6f449 + 358a5ee commit 2ba3a6b
Show file tree
Hide file tree
Showing 16 changed files with 21 additions and 287 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/deploy-to-nexus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,9 @@ jobs:
echo "${{ secrets.GPG_FILE }}" > sec.gpg.asc
gpg -d --passphrase "${{ secrets.GPG_FILE_PSWD }}" --batch sec.gpg.asc > sec.gpg
fastlane deployNexus
- name: Nexus release
uses: Propromp/nexus-release@1
with:
groupId: "no.nordicsemi.android.common" # Group id of the repository
nexusUsername: ${{ secrets.OSSR_USERNAME }} # User name of the nexus repository manager
nexusPassword: ${{ secrets.OSSR_PASSWORD }} # Password of the nexus repository manager
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import no.nordicsemi.android.common.navigation.internal.NavigationManager

@Module
@InstallIn(ActivityRetainedComponent::class)
internal interface NavigationModule {
interface NavigationModule {

@Binds
fun bindNavigator(navigator: NavigationManager): Navigator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import javax.inject.Inject
* result.
*/
@ActivityRetainedScoped
internal class NavigationManager @Inject constructor(
class NavigationManager @Inject constructor(
@ApplicationContext private val context: Context,
) : Navigator {
/** The navigation events class. */
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ dependencyResolutionManagement {
}
versionCatalogs {
create("libs") {
from("no.nordicsemi.android.gradle:version-catalog:1.5.10")
from("no.nordicsemi.android.gradle:version-catalog:1.6.5")
}
}
}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ fun LoggerAppBarIcon(
contentDescription = stringResource(id = R.string.open_logger),
onClick = onClick
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import androidx.compose.runtime.setValue
import androidx.compose.ui.res.stringResource
import no.nordicsemi.android.common.ui.scanner.main.DeviceListItem
import no.nordicsemi.android.common.ui.scanner.view.ScannerAppBar
import no.nordicsemi.android.kotlin.ble.scanner.data.BleScanResults
import no.nordicsemi.android.kotlin.ble.core.scanner.BleScanResults

@Composable
fun ScannerScreen(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

package no.nordicsemi.android.common.ui.scanner

import no.nordicsemi.android.kotlin.ble.scanner.data.BleScanResults
import no.nordicsemi.android.kotlin.ble.core.scanner.BleScanResults

sealed interface ScannerScreenResult

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import no.nordicsemi.android.common.ui.scanner.main.DevicesListView
import no.nordicsemi.android.common.ui.scanner.main.viewmodel.ScannerViewModel
import no.nordicsemi.android.common.ui.scanner.repository.ScanningState
import no.nordicsemi.android.common.ui.scanner.view.internal.FilterView
import no.nordicsemi.android.kotlin.ble.scanner.data.BleScanResults
import no.nordicsemi.android.kotlin.ble.core.scanner.BleScanResults

@OptIn(ExperimentalMaterialApi::class)
@Composable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
Expand All @@ -46,7 +45,7 @@ import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import no.nordicsemi.android.common.ui.scanner.R
import no.nordicsemi.android.common.ui.scanner.repository.ScanningState
import no.nordicsemi.android.kotlin.ble.scanner.data.BleScanResults
import no.nordicsemi.android.kotlin.ble.core.scanner.BleScanResults

@Suppress("FunctionName")
fun LazyListScope.DeviceListItems(
Expand All @@ -65,8 +64,8 @@ fun LazyListScope.DeviceListItems(
modifier = Modifier.padding(start = 8.dp, bottom = 8.dp)
)
}
items(bondedDevices) { device ->
ClickableDeviceItem(device, onClick, deviceView)
items(bondedDevices.size) {
ClickableDeviceItem(bondedDevices[it], onClick, deviceView)
}
}

Expand All @@ -79,8 +78,8 @@ fun LazyListScope.DeviceListItems(
)
}

items(discoveredDevices) { device ->
ClickableDeviceItem(device, onClick, deviceView)
items(discoveredDevices.size) {
ClickableDeviceItem(discoveredDevices[it], onClick, deviceView)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import no.nordicsemi.android.common.theme.NordicTheme
import no.nordicsemi.android.common.ui.scanner.repository.ScanningState
import no.nordicsemi.android.common.ui.scanner.view.internal.ScanEmptyView
import no.nordicsemi.android.common.ui.scanner.view.internal.ScanErrorView
import no.nordicsemi.android.kotlin.ble.scanner.data.BleScanResults
import no.nordicsemi.android.kotlin.ble.core.scanner.BleScanResults

@Composable
fun DevicesListView(
Expand Down
Loading

0 comments on commit 2ba3a6b

Please sign in to comment.