Fix short lived callback lifetimes #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, but this MR requires needless object dereference on each lookup, compared with #88 (each callback method call). |
arg0d
force-pushed
the
kristupas/fix-callback-lifetimes-2
branch
from
10741a7 to
8175b7a
Compare
Signed-off-by: Kristupas Antanavičius <[email protected]>
arg0d
force-pushed
the
kristupas/fix-callback-lifetimes-2
branch
from
8175b7a to
7171b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #88.
I like this one better, there is 1 less dictionary lookup.
I tried to use a struct ("stack" allocated), but C# does not allow to modify struct in-place in dictionary, so modifying refcount in a struct requires 2 lookups. Compared with a single object dereference in this MR, I think object dereference is the better option?