-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dry deposition working with FATES-NOCOMP #11
Conversation
@rosiealice - I think it would not be easier to make 2 PRs here.
|
Yes, it would be good to bring noresm up to date with NGEET/ FATES main. For some reason I could not see the noresm branch this morning, but I do think it would be better if there was another PR before this one to update it. I can try and have a go... Note that the NorESMhub/CTSM tags we are using currently point to a NGEET/FATES tag and not here.. https://github.com/NorESMhub/NorESM/blob/noresm2_5_alpha06/Externals_CLM.cfg |
Replaced by #13 |
closing this PR as it is redundant. |
These are the FATES-side changed for making FATES-NOCOMP mode work with dry deposition.
The noresm branch appears to be somewhat behind the FATES main, hence the large number of apparent differences.
This code runs in coupled mode and produces valid outputs. Analysis of the validity of their magnitudes is ongoing.
A follow-up PR will introduce the scientifically useful calculation of the seasons. This PR is just to make the code function at all.
Description:
Collaborators:
@mvdebolskiy
@mvertens
@maritsandstad
@kjetilaas
Expectation of Answer Changes:
Answers are expected to change, but only for the dry deposition fields. It is hard to assess the impact of these answer changes as these fields were not generated before and the model version that generates them did not function prior to this PR.
But nothing else should change except for the dry deposition fields.
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: