removed unneeded xml variables #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvertens thanks for doing this! I was happy to see this being worked on. I was figuring I'd need to do this on my own at some point, so happy to see that you did it for me. So this will come to the ESCOMP fork, when the NorESMFhub fork is merged to ESCOMP? I assume that is something that will happen on occasion? I highly endorse that kind of thing happening, so I'm hoping that's the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes #
Specific notes
There XML variables removed that can be set, but don't actually do anything (changing them doesn't change the value in nuopc.runconfig). As such they should be removed from the XML. You could still set them if needed in the user_nl_cpl file.
Contributors other than yourself, if any: None
CMEPS Issues Fixed: ESCOMP#362
Are changes expected to change answers? bfb
Any User Interface Changes? No
Testing performed
Verified that these xml variables were removed