Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testdefs, BLOM hybrid is now default #484

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Update testdefs, BLOM hybrid is now default #484

merged 1 commit into from
Feb 8, 2025

Conversation

TomasTorsvik
Copy link
Contributor

BLOM hybrid is now default in the master branch. Using testmods="blom/hybrid" results in error at SETUP stage:

ERROR: BLOM_VCOORD == cntiso_hybrid and BLOM_TURBULENT_CLOSURE ==  is not a valid combination'

This PR removes the "blom/hybrid" testmods.

@TomasTorsvik TomasTorsvik self-assigned this Feb 7, 2025
@TomasTorsvik TomasTorsvik added the bug Something isn't working label Feb 7, 2025
@TomasTorsvik TomasTorsvik added this to the BLOM v1.7.1 tag milestone Feb 7, 2025
@TomasTorsvik TomasTorsvik merged commit c68c84e into NorESMhub:master Feb 8, 2025
4 checks passed
@TomasTorsvik TomasTorsvik deleted the main_update_testdefs branch February 8, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorgSchwinger JorgSchwinger JorgSchwinger approved these changes

@matsbn matsbn Awaiting requested review from matsbn matsbn is a code owner

@jmaerz jmaerz Awaiting requested review from jmaerz jmaerz is a code owner

Assignees

@TomasTorsvik TomasTorsvik

Labels
bug Something isn't working
Projects
NorESM Development
Status: Done
Milestone
BLOM v1.7.1 tag
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasTorsvik @JorgSchwinger