Update M4AGO to v1.1.1 (equiv. to dev-1.1.1) #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTorsvik
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
@jmaerz - thanks, looks good to me.
I will make a milestone for a new tag on the release-1.6 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the release-branch 1.6 updates the thus far optional M4AGO sinking scheme to the more robust version v1.1.1 (which is equivalent to version dev-1.1.1). Minor changes in M4AGO results can be expected (see M4AGO release notes: https://github.com/jmaerz/M4AGO-sinking-scheme/releases/tag/v1.1.0 and https://github.com/jmaerz/M4AGO-sinking-scheme/releases/tag/v1.1.1)
The new version has also been introduced in
mastervia PR #460 and is part of BLOM tag 1.7.Tested in PR #460 and this branch via
single_columntest case.