Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI test for macOS #434

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

TomasTorsvik
Copy link
Contributor

@TomasTorsvik TomasTorsvik commented Nov 25, 2024

  • Comment out macOS test. Can easily be enabled again if someone wants to try using it.
  • git should ignore byte-compiled python files

If approved, a similar PR will be included in release-1.6 and master branches.

@TomasTorsvik TomasTorsvik self-assigned this Nov 25, 2024
@TomasTorsvik TomasTorsvik added the CI/meson Issues related to CI builds and/or meson label Nov 25, 2024
@TomasTorsvik TomasTorsvik linked an issue Nov 25, 2024 that may be closed by this pull request
@TomasTorsvik TomasTorsvik linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TomasTorsvik ,
I am little experienced with github ci, but since the main code employment is on the HPC system close to ubuntu, it sounds reasonable to switch off the macOS support as long as no such system is frequently used (while of course, macOS users may wish to check the build on their system from time to time).

@TomasTorsvik
Copy link
Contributor Author

I will wait with merging this until tomorrow, in case someone has suggestions for a fix of the macOS build procedure.

@TomasTorsvik TomasTorsvik merged commit c5e40e0 into NorESMhub:release-1.4 Nov 26, 2024
4 checks passed
@TomasTorsvik TomasTorsvik deleted the r1.4_test_ci_fix branch November 26, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/meson Issues related to CI builds and/or meson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for macOS is broken Add __pycache__ directories to .gitignore
3 participants