Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diagnostic writing for coupled N-deposition #418

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix diagnostic writing for coupled N-deposition #418

merged 1 commit into from
Oct 23, 2024

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Oct 23, 2024

This PR fixes the writing of diagnostics for N-deposition. It has been already fixed in master by PR #410.

@jmaerz jmaerz added this to the NorESM2.3 - BLOM/iHAMOCC milestone Oct 23, 2024
@jmaerz jmaerz requested a review from TomasTorsvik October 23, 2024 14:06
@jmaerz jmaerz self-assigned this Oct 23, 2024
TomasTorsvik
TomasTorsvik approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaerz - approved!
Is this all that you what you want to "cherry-pick" from #410 into the release-1.6 branch?

@jmaerz
Copy link
Collaborator Author

jmaerz commented Oct 23, 2024

Hi @TomasTorsvik , yes, I think so - in NorESM2.3, MCT is still the default, if I am not mistaken?!

@TomasTorsvik
Copy link
Contributor

Hi @TomasTorsvik , yes, I think so - in NorESM2.3, MCT is still the default, if I am not mistaken?!

Yes, that is correct.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Oct 23, 2024

Then I am not seeing any reason to pick more than this change from #410. Or do you?

@TomasTorsvik
Copy link
Contributor

Then I am not seeing any reason to pick more than this change from #410. Or do you?

No, I think it's fine.

@jmaerz jmaerz merged commit b1d38c3 into NorESMhub:release-1.6 Oct 23, 2024
6 checks passed
@jmaerz jmaerz deleted the fix-ndep-coupling branch October 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTorsvik TomasTorsvik TomasTorsvik approved these changes

Assignees

@jmaerz jmaerz

Labels
None yet
Projects
None yet
Milestone
NorESM2.3 - BLOM/iHAMOCC
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaerz @TomasTorsvik