Properly declare and initialize bifrXX_ini and clean mo_biomod from growth_co2 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgSchwinger
approved these changes
Nov 20, 2023
jmaerz
merged commit 0196525
into
NorESMhub:feature-hamocc_beyond-CMIP6
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TomasTorsvik and @JorgSchwinger , this is the PR to properly declare and initialize the
bifrXX. In addition, I cleanedmo_biomodfromgrowth_co2since it was/is only used as local variable inmo_ocprod.After this PR, I believe that the
beyond-CMIP6branch is ready to be merged intomaster, which eventually breaks CMIP6 backward compatibility ofmasterand makes it ready for NorESM2.1. Technically, the tagging #295 can then still be included inmaster...