Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TomasTorsvik and @JorgSchwinger , in connection to PR #243, I checked the OMP private statement in
carchm
. Indeed a number of local real values were not included (I am aware that loop indices are private by default, but it doesn't harm to be even more explicit) - probably most importantly also for the Si units:rrho
. The fix is only related tocarchm
. In combination with the fix in #243, variations in DIC inventories during the first time steps disappear. I hope, no further local real value escaped my investigation. Upon request, I sort in the values in the OMP statement (for now I thought it is easier to see the changes). Issues with the sinking in OCPROD still remain (I guess, the easiest would be to un-OMP the settling to avoid race conditions fork
versuskdonor
).