Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix on buildnml after incomplete shell variable renaming from PR 224 #234

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

TimotheeBrgs
Copy link
Collaborator

@TimotheeBrgs TimotheeBrgs commented Jan 31, 2023

A proposed commit has been suggested in PR 224 to include a new naming convention for shell variables in buildnml. I had approved the commit but there was 2 missing renaming that I missed. The code compiles correctly with this PR.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Timothee!
Since this is a straight forward bug fix, we can do without a lengthy review :)

@TomasTorsvik TomasTorsvik added iHAMOCC Issue mainly concerns the iHAMOCC code base bug Something isn't working labels Jan 31, 2023
@TomasTorsvik TomasTorsvik merged commit 311b859 into NorESMhub:master Jan 31, 2023
@TimotheeBrgs TimotheeBrgs deleted the fix_buildnml branch January 31, 2023 14:37
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Quick fix on buildnml after incomplete shell variable renaming from PR 224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants