pCO2, Piston velocity and solubility output #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaerz
added
enhancement
TomasTorsvik
approved these changes
Nov 21, 2022
Co-authored-by: Tomas Torsvik <[email protected]>
| ! KWCO2 - kwco2 | ||
| ! KWCO2KH - kwco2 x solubility (moist air) | ||
| ! CO2KHD - khd CO2 solubility under dry air assumption | ||
| ! CO2KH - kh CO2 solubility under moist air assumption | ||
| ! CO2FXD - Downward CO2 flux (co2fxd) [kg C m-2 s-1] |
There was a problem hiding this comment.
Regarding the naming of of these variables, I find it confusing that sometimes a "D" for dry is appended, and sometimes a "M" for moist, and sometimes nothing. I would suggest to use only "M" to indicate the moist air assumption:
! PCO2M - Surface PCO2 under moist air assumption [uatm]
! KWCO2 - kwco2
! KWCO2KHM - kwco2 x solubility (moist air)
! CO2KH - khd CO2 solubility under dry air assumption
! CO2KHM - kh CO2 solubility under moist air assumption
I see that the idea was to use names that are close to the values in the code, but in the namelist, it should make sense for users that have no insights in the code. To resolve this one could also rename kh -> khm and khd -> kh in carchm, but not sure if this would make sense
There was a problem hiding this comment.
I can do this. One question though was/is the issue with previous names and potential confusion about it during subsequent cmorization steps. Any opinion/insights/knowledge about this? I tried to keep the former names, if possible.
There was a problem hiding this comment.
What is important is that PCO2 is not changed (since this was/is of course used in cmorization). Everything else is not CMIP6 output. So the only potential confusion is that KWCO2 will change its meaning, but this was actually very confusing before, so this is an improvement (not backwards-compatible though).
There was a problem hiding this comment.
I think this should still be fine, but we should remember to mention the change in KWCO2 in the CHANGELOG (for both BLOM/iHAMOCC-1.3.0 and NorESM-2.0.6)
|
And yes, the 1e-6 (or 1e6) converts atm to microatm, I think. |
|
Hi @JorgSchwinger and @TomasTorsvik , I tried to adopt your suggestions with the last commit. |
| kwco2sol(i,j) = kwco2*Kh*1e-6 | ||
|
|
||
| kwco2sol(i,j) = kwco2*Kh*1e-6 !m/s mol/kg/muatm | ||
| kwco2d(i,j) = kwco2 ! m/s (incl. ice fraction!) |
There was a problem hiding this comment.
The naming is also a bit confusing here, because the piston velocity is not changed by dry/moist assumptions. Since kwco2 is already taken a different name as "piston" or "vp" or so might be an alternative. Sorry quite picky, can go without changing this.
There was a problem hiding this comment.
Ok, I read the pco2d formerly as 2D (not dry) as opposed to pco2 (as local variable) - so extended it to kwco2d, since a local variable kwco2 is already provided .... - didn't want to rewrite the code.
cime_config/buildnml
Outdated
| ! PCO2M - Surface PCO2 under moist air assumption [uatm] | ||
| ! KWCO2 - kwco2 | ||
| ! KWCO2KHM - kwco2 x solubility (moist air) | ||
| ! CO2KH - khd CO2 solubility under dry air assumption |
There was a problem hiding this comment.
Would be nice to stick to the convention used for the other namamelist entries, e.g.
CO2KH - CO2 solubility under dry air assumption (khd) [mol/kg/atm]
There was a problem hiding this comment.
I hope the last commit satisfies the conventions. I left the other comment untouched (kwco2d) for the mentioned reasons. I hope that's ok.
JorgSchwinger
approved these changes
Nov 22, 2022
TomasTorsvik
pushed a commit
to TomasTorsvik/BLOM-TTfork
that referenced
this pull request
Dec 5, 2022
* add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility)
TomasTorsvik
pushed a commit
to TomasTorsvik/BLOM-TTfork
that referenced
this pull request
Dec 5, 2022
* add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility)
jmaerz
added a commit
that referenced
this pull request
Jan 25, 2023
* Dynamic mapping of pore water tracers to ocean tracers (#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * Hamocc hybrid coord2 (#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * Fix porosity read (#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (#212) Fixed sediment clay units. * Add option for surface pH output (#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (#225) Co-authored-by: Mats Bentsen <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Jörg Schwinger <[email protected]>
jmaerz
added a commit
that referenced
this pull request
Feb 9, 2023
* Dynamic mapping of pore water tracers to ocean tracers (#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * This is the first commit of MKS units. All variables in the subroutines have been converted to MKS [meter, kg, seconds] instead of CGS [cm, gram, seconds] with necessary coefficients. The default option which is CGS reproduce old results. The new option MKS cannot reproduce because of machine precision. * Hamocc hybrid coord2 (#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * BLOM CIME cpp updates to run in NorESM * bug fixes for the CGS MKS conversion * cesm thermal forcing bug fixes for reproducibility * BLOM MKS update to export winds into the CESM using proper units. * input values in ocn_in case is updated for mks setup * default cgsmks value changed * Initialize some variables in the k-epsilon model. * Fix porosity read (#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (#212) Fixed sediment clay units. * - Made the "fuk95" configuration work with MKS units. - Removed "CGS" CPP flag. - Changed some unit conversion factors from variables to parameters. - Introduced rho0 (= 1/alpha0) parameter. - Updated copyright statements. * Correct unit conversion of mixed layer depth to pressure. * Updated NorESM coupling scripts for the use of MKS units. * Fixed check of unit system when building as NorESM component. * Add option for surface pH output (#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (#225) * fix missing ' (#228) Fixing a missing ' that only showed up when using `cisonew` --------- Co-authored-by: Mats Bentsen <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Mehmet Ilicak <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Jörg Schwinger <[email protected]>
jmaerz
added a commit
to jmaerz/BLOM
that referenced
this pull request
Aug 9, 2023
* add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility)
jmaerz
added a commit
to jmaerz/BLOM
that referenced
this pull request
Aug 9, 2023
* add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility)
jmaerz
added a commit
to jmaerz/BLOM
that referenced
this pull request
Aug 9, 2023
* Dynamic mapping of pore water tracers to ocean tracers (NorESMhub#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (NorESMhub#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (NorESMhub#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * Hamocc hybrid coord2 (NorESMhub#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * Fix porosity read (NorESMhub#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (NorESMhub#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (NorESMhub#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (NorESMhub#212) Fixed sediment clay units. * Add option for surface pH output (NorESMhub#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (NorESMhub#225) Co-authored-by: Mats Bentsen <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Jörg Schwinger <[email protected]>
jmaerz
added a commit
to jmaerz/BLOM
that referenced
this pull request
Aug 9, 2023
…b#232) * Dynamic mapping of pore water tracers to ocean tracers (NorESMhub#192) * Initial restructuring of sediment-related tracer declaration and initialization * Introducing mapping function * Remove unncessary comments * Fixed diagnostics bug and updated index naming * Added initial support for NUOPC driver. * Lon-lat variable sediment porosity (NorESMhub#189) Introducing a static 3D sediment porosity field that can be optionally read in with effects on molecular pore water diffusion and shifting. * Added wave forcing fields. * Renamed folder for MCT driver. * Moved MCT specific file from drivers/cpl_share/ to drivers/mct/. * Rename drivers/mct/mod_swtfrz.F to drivers/mct/mod_swtfrz.F90. * Rewrite to drivers/mct/mod_swtfrz.F90 to free format Fortran. * Remove redundant definition of kOBL. * Redefine kOBL, cast as integer * Fixing variable sediment porosity - field initialization in case of `sedbypass=true` (NorESMhub#198) * Removing bodensed - Initialization of sediment parameters and fields now in mo_sedmnt * This is the first commit of MKS units. All variables in the subroutines have been converted to MKS [meter, kg, seconds] instead of CGS [cm, gram, seconds] with necessary coefficients. The default option which is CGS reproduce old results. The new option MKS cannot reproduce because of machine precision. * Hamocc hybrid coord2 (NorESMhub#179) Make the surface mixed layer depth fractional index `hOBL` available for use in iHAMOCC, and adjust the internal iHAMOCC index `kmle` according to `hOBL`. Default value `kmle = 2` is retained for consistency with isopycnic coordinates. * BLOM CIME cpp updates to run in NorESM * bug fixes for the CGS MKS conversion * cesm thermal forcing bug fixes for reproducibility * BLOM MKS update to export winds into the CESM using proper units. * input values in ocn_in case is updated for mks setup * default cgsmks value changed * Initialize some variables in the k-epsilon model. * Fix porosity read (NorESMhub#201) * Fixing the reading of variable porosity input field in preparation for the NorESM 2.0.6 release Cherry-picked from private Ncycleprivate branch 0d56930e2fdd62caba964d375b57304942568926 * Provide number of layers (3rd dim) via ks and not hard-coded * minor clean-up * Correct unit of diagnostic variable dp_trc. * Made conservation and checksum diagnostics selectable by namelist options (default off). * pCO2, Piston velocity and solubility output (NorESMhub#202) * add pCO2m (moist), CO2 piston velocity and solubility output - caution: kwco2 piston velocity now really holds only piston velocity (and not times solubility) * Bugfix pnetcdf (NorESMhub#208) * Add variables used by PNETCDF to explicit use staements. * Move implicit none statments * update explicit use statement for pnetcdf * fixed units and renamed calcium burial to CaCO3 burial (NorESMhub#212) Fixed sediment clay units. * - Made the "fuk95" configuration work with MKS units. - Removed "CGS" CPP flag. - Changed some unit conversion factors from variables to parameters. - Introduced rho0 (= 1/alpha0) parameter. - Updated copyright statements. * Correct unit conversion of mixed layer depth to pressure. * Updated NorESM coupling scripts for the use of MKS units. * Fixed check of unit system when building as NorESM component. * Add option for surface pH output (NorESMhub#221) * Remove unused parameters in wrt* subroutine calls in ncout_hamocc.F90 * Import get_bgc_namelist only in subroutine where it is needed. (NorESMhub#225) * fix missing ' (NorESMhub#228) Fixing a missing ' that only showed up when using `cisonew` --------- Co-authored-by: Mats Bentsen <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Mehmet Ilicak <[email protected]> Co-authored-by: Tomas Torsvik <[email protected]> Co-authored-by: Jörg Schwinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomas, hi Jörg,
I added output for pCO2 under moist air assumption (which can actually make quite some difference - up to ca. O(10ppm)), pure piston velocity, and solubility under dry and moist air assumption. There are two things to note, though:
kwco2now really only holds the Piston velocity (not times solubility anymore) - Piston times solubility (moist air, as before) is available viakwco2khnow. Does that change need some changes in any cmorization packages (which I am currently not fully aware of)?kwco2sol(i,j) = kwco2*Kh*1e-6(WHY 1e-6???, carchm l. 533) From my understanding,kwco2has units of m/s andKhmol/kg/atm - so to which units were/is it converted to? Should it be per µatm?Another thing might be, if we want to keep track of the air-pressure correction
rpp0used for calculating CO2 fluxes (which affects the gas saturation).Closes #31