Fix Ghost Block appearing when clicking on a cake #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exaxxion
requested changes
Mar 4, 2021
There was a problem hiding this comment.
Looks like the problem was what I guessed it might be. Thanks for looking into this.
I think it is still desirable for the function to return false at the end if things were otherwise not handled. It should suffice to move the return true; on line 154 outside of the inner if block, so it always returns true if it gets into the else if on line 148.
|
I made this change and it appears to work just the same, so it is now implemented. |
Exaxxion
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix this issue, all I had to do was change the final return from false to true, to tell MC that we handled the
onBlockActivated()call, ensuring that no block will be placed.Closes #12