Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preliminary docs for queries #928

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Add preliminary docs for queries #928

merged 14 commits into from
Apr 11, 2024

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Apr 8, 2024

Closes #915

@Xanewok Xanewok requested a review from a team as a code owner April 8, 2024 10:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c846917

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Xanewok Xanewok marked this pull request as draft April 8, 2024 10:34
AntonyBlakey
AntonyBlakey suggested changes Apr 8, 2024
View reviewed changes
documentation/public/user-guide/query-language.md Outdated
When matching patterns, you may want to process specific nodes within the
pattern. Captures allow you to associate names with specific nodes in a pattern,
so that you can later refer to those nodes by those names. Capture names are
written _after_ the nodes that they refer to, and start with an `@` character.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before

@Xanewok Xanewok marked this pull request as ready for review April 8, 2024 16:48
@Xanewok
Copy link
Contributor Author

Xanewok commented Apr 8, 2024

Marking as ready for review since I'd greatly appreciate the input on how-tos; I still need to do another pass for the query language chapter.

@Xanewok
Copy link
Contributor Author

Xanewok commented Apr 9, 2024

I have adapted and tested the queries in the Tree Query Language chapter as well in ca13cfc; I'd appreciate taking a look at that as well 🙏

OmarTawfik
OmarTawfik approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions on misnamed variables/files.
Otherwise, LGTM!

Great work! Thanks.

@Xanewok Xanewok enabled auto-merge April 11, 2024 14:35
@Xanewok Xanewok added this pull request to the merge queue Apr 11, 2024
Merged via the queue into NomicFoundation:main with commit 92c7b64 Apr 11, 2024
1 check passed
@Xanewok Xanewok deleted the query-docs branch April 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

@AntonyBlakey AntonyBlakey AntonyBlakey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CST queries documentation
3 participants
@Xanewok @AntonyBlakey @OmarTawfik