New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Rule/Token => Nonterminal/Terminal rename #834

Closed

3 tasks done

Xanewok opened this issue Feb 19, 2024 · 0 comments · Fixed by #971

Closed

3 tasks done

Consider Rule/Token => Nonterminal/Terminal rename #834

Xanewok opened this issue Feb 19, 2024 · 0 comments · Fixed by #971

Assignees

Contributor

Xanewok commented Feb 19, 2024 •

edited by OmarTawfik

Loading

Split from #640.

Rename TokenKind to TerminalKind, since it will also refer to trivia.
Rename RuleKind to NonTerminalKind, since "rule" is ambiguous.
Rename LabelKind to EdgeKind, and LabeledXXX to Edge

Xanewok self-assigned this

Xanewok added this to Slang - 2024 H1

github-project-automation bot moved this to ⏳ Todo in Slang - 2024 H1

Xanewok mentioned this issue

public API changes #640

Closed

7 tasks

OmarTawfik mentioned this issue

Generify CST/Cursor/Query #930

Closed

Xanewok moved this from ⏳ Todo to 🔄 In Progress in Slang - 2024 H1

Xanewok mentioned this issue

refactor!: Rename RuleKind, TokenKind and NodeLabel #971

Merged

github-merge-queue bot pushed a commit that referenced this issue


          refactor!: Rename RuleKind, TokenKind and NodeLabel (#971)

be943b7

Closes #834 😭

Xanewok closed this as completed in #971

github-project-automation bot moved this from 🔄 In Progress to ✅ Done in Slang - 2024 H1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment