Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit trivia as sibling tokens and don't generate a RuleKind for it #737

Closed
5 tasks done
Xanewok opened this issue Jan 11, 2024 · 0 comments · Fixed by #885
Closed
5 tasks done

Emit trivia as sibling tokens and don't generate a RuleKind for it #737

Xanewok opened this issue Jan 11, 2024 · 0 comments · Fixed by #885
Assignees
@Xanewok

Comments

@Xanewok
Copy link
Contributor

Xanewok commented Jan 11, 2024 •
edited by OmarTawfik
Loading

As discussed f2f.

  • Remove LeadingTrivia and TrailingTrivia non-terminals.
  • Include the underlying trivia as siblings to the other rules/tokens in the parent directly.
  • Use FieldName::LeadingTrivia and FieldName::TrailingTrivia for the promoted siblings.
  • Remove fn is_trivia() for RuleKind, since it is impossible for any variant.
  • Implement fn is_trivia() correctly for TokenKind based on Item::Trivia, instead of returning false. (Fix parsing ambiguous call options #862)
@Xanewok Xanewok self-assigned this Jan 11, 2024
@Xanewok Xanewok mentioned this issue Jan 15, 2024
Closed
@OmarTawfik OmarTawfik mentioned this issue Jan 19, 2024
Closed
7 tasks
@OmarTawfik OmarTawfik moved this to Todo in Slang - 2024 H1 Feb 13, 2024
@OmarTawfik OmarTawfik mentioned this issue Feb 20, 2024
Closed
This was referenced Mar 5, 2024
Merged
Merged
@Xanewok Xanewok moved this from ⏳ Todo to 🔄 In Progress in Slang - 2024 H1 Mar 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
@Xanewok
Emit trivia as sibling tokens and don't generate a RuleKind for it (#…
a9bd8da 
…885)

Closes #737 



Functionally it's done but needs a rebase and a final polish. For now
I'm using the existing PG infra until we clean it up (#638, slated for
this sprint as well).
@github-project-automation github-project-automation bot moved this from 🔄 In Progress to ✅ Done in Slang - 2024 H1 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
None yet
Projects
No open projects
Slang - 2024 H1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit trivia as sibling tokens and don't generate a RuleKind for it Xanewok/slang
1 participant
@Xanewok