Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardhat package resolution #5918

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

alcuadrado
Copy link
Member

The resolution was giving different results during testing than in production, due to everything being in dist/ in production builds. Instead of using a path, I now look for the closest package.json, which is safer.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 0:07am

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: c8d2623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 1, 2024
@alcuadrado alcuadrado merged commit 9cbc645 into v-next Nov 1, 2024
48 checks passed
@alcuadrado alcuadrado deleted the fix-hardhat-package-resolution branch November 1, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant