-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add pnpm to document #5670
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
According to the docs it does install peer dependencies: https://pnpm.io/npmrc#auto-install-peers |
|
I think you may be correct. I created this issue in the pnpm repo to better understand the situation: pnpm/pnpm#8463 |
Sorry, after trying and researching, I found that pnpm does automatically install peer dependencies. I just need to add the package to the package.json file when I want to use it in my code. I will update the code in the PR and verify each command. |
I believe you are right, @iosh, and we need to add pnpm to the doc and manually list most peer dependencies, at least the ones that the user would require/import. |
I tried npm, which allows users to import/require packages not added to package.json. but pnpm doesn't allow this, so I think this PR is okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this PR, and for your patience @iosh. I was confused about the topic.
I believe that we can be a bit less verbose (see my comment), but we can play safe and do the full list for now. WDYT?
@alcuadrado Thank you for your guidance, I agree with your suggestions. I have another question - I want to contribute to Hardhat, but I am unsure where to start. Do you have any suggestions for me? I want to spend some time to Hardhat every week. |
We've got a confirmation from a maintainer of pnpm pnpm/pnpm#8463 (comment)
Maybe look for simple bugs in the issue and tag any of us to learn more about it. Or hit me up on telegram. |
I have update the pnpm installation command to only list the packages that the user needs to require/import.
Hardhat has many issues, I don't know which one i can do. maybe add like |
This is a good one: #5696 |
Oops, I forgot to click the merge button |
pnpm
to documentBy default, pnpm does not automatically install peer dependencies. To enable this behavior, users must set auto-install-peers=true in the .npmrc file. So I need to list all packages as I would when using yarn.Update: pnpm is automatically install peer dependencies, if user want use the package in code, user need to add it as a dependency