Use custom state manager as a temporal fix to a bug in DefaultStateManager #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
HardhatStateManager, based offForkStateManager, which keeps everything in memory in a flat structure (i.e. no MPTs involved). This means that our blocks always have an incorrect state root now. Before this PR this only happened when forking.ForkStateManagerdoesn't support hardforks before Spurious Dragon, as it's not possible to do that when fetching the accounts via the rpc. We kept the same limitation inHardhatStateManagerto avoid introducing extra complexity, so we also forbid older hardforks in the config.This change should be reverted soon, once
DefaultStateManagergets fixed.