Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use uri instead of path for clearing diagnostics on valid compilation #360

Merged
merged 3 commits into from
Jan 9, 2023
Merged

fix: use uri instead of path for clearing diagnostics on valid compilation #360

merged 3 commits into from
Jan 9, 2023

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Jan 5, 2023

Closes #355

@antico5 antico5 force-pushed the use_uris_on_publish_diagnostics branch from 711ceb9 to 71d4c12 Compare January 5, 2023 16:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (development@9b56d3c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 72433c0 differs from pull request most recent head 71d4c12. Consider uploading reports for the commit 71d4c12 to get more accurate results

@@              Coverage Diff               @@
##             development     #360   +/-   ##
==============================================
  Coverage               ?   57.03%           
==============================================
  Files                  ?      174           
  Lines                  ?     4336           
  Branches               ?      707           
==============================================
  Hits                   ?     2473           
  Misses                 ?     1629           
  Partials               ?      234

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kanej
kanej approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antico5 antico5 merged commit 69ea6ce into development Jan 9, 2023
@antico5 antico5 deleted the use_uris_on_publish_diagnostics branch January 9, 2023 15:15
antico5 added a commit that referenced this pull request Jan 9, 2023
@antico5
fix: use uri instead of path for clearing diagnostics on valid compil…
91c066b 
…ation (#360)

* fix: use uri instead of path for clearing diagnostics on valid compilation

* fix linting

* fix: diagnostics on foundry on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URI must contain a scheme
3 participants
@antico5 @codecov-commenter @kanej