Adding light theme based on operating system settings #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #225
What
This pull request extracts all CSS colors out into CSS variables and adds support for light mode.
Here are some screenshots (I'm not a designer, so if the colors are off I'm open for suggestions):
How
Extracting colors into variables makes it able to be reused throughout the code and just having a set palette to reference. It makes it more consistent and easier to change.
In this case the light mode just sets different values for the variable and the rest of the rendering stays as is.
One thing to note here is that the SVG for the color scale is now also theme based. This is achieved by using
currentColor
in the SVG code which allows it to be styled with CSS.Compatibility
In a "modern" browser everything should work. IE is definitely not supported but here is the full list of features and their adoption rate: