Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal handler should not call exit() #42

Closed
NoiseByNorthwest opened this issue Apr 4, 2018 · 0 comments · Fixed by #47
Closed

Signal handler should not call exit() #42

NoiseByNorthwest opened this issue Apr 4, 2018 · 0 comments · Fixed by #47
Assignees
@NoiseByNorthwest
Labels
security

Comments

@NoiseByNorthwest
Copy link
Owner

As exit() is not a "safe function", see Async-signal-safe functions in man 7 signal.
@NoiseByNorthwest NoiseByNorthwest self-assigned this Apr 4, 2018
NoiseByNorthwest added a commit that referenced this issue May 9, 2018
@NoiseByNorthwest
Fix ownership issue & fix #42
e75bee0 
- Profiler object does not have anymore the responsability to destroy its passed (at creation time) reporter
- Signal handler does not call `exit()` anymore (fix #42)
@NoiseByNorthwest NoiseByNorthwest mentioned this issue May 9, 2018
Merged
NoiseByNorthwest added a commit that referenced this issue May 10, 2018
@NoiseByNorthwest
Fix ownership issue & fix #42
35189ec 
- Profiler object does not have anymore the responsability to destroy its passed (at creation time) reporter
- Signal handler does not call `exit()` anymore (fix #42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoiseByNorthwest NoiseByNorthwest

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ownership issue & fix #42 NoiseByNorthwest/php-spx
1 participant
@NoiseByNorthwest