Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @nodesecure/authors #62

Merged
merged 17 commits into from
Feb 12, 2023
Merged

feat: add @nodesecure/authors #62

merged 17 commits into from
Feb 12, 2023

Conversation

Kawacrepe
Copy link
Member

@Kawacrepe Kawacrepe commented Aug 14, 2022

Related to NodeSecure/authors#10

Also:

  • update deps
  • remove .jest file

@Kawacrepe Kawacrepe marked this pull request as ready for review August 14, 2022 19:16
@Kawacrepe
Copy link
Member Author

We may want to create a different issue about the TODO I put in the code.
This is mostly related to RC, we may want to give this opportunity to someone who wants to start contributing.

It consist in adding flags & domainInformations in RC and use em in scanner

@NodeSecure NodeSecure deleted a comment from Kawacrepe Aug 15, 2022
@fraxken
Copy link
Member

fraxken commented Aug 15, 2022

@Kawacrepe
Copy link
Member Author

@fraxken What do you think about this kind of payload ?

{
  warnings: {
    globals: globalsWarning,
    flaggedAuthors: xx.filter((el) => el.flagged === true))
  },
  authors,
}

It may be future-proof (I'm thinking about nodesecure/rc atm)

@fraxken
Copy link
Member

fraxken commented Sep 2, 2022

@Kawacrepe do we really need to touch the global warnings key ? Because for me if the flag information is in the list of authors we do not need to repeat the information.

Then for me it's the responsability of tools to filter flagged authors (like in Scanner / UI / CI ..).

@Kawacrepe
Copy link
Member Author

Oh okay, looks like I didn't understood one of your messages in the discord channel

@Kawacrepe Kawacrepe changed the title refacto authors feat: add @nodesecure/authors Jan 10, 2023
@Kawacrepe Kawacrepe requested a review from fraxken January 13, 2023 17:56
@fraxken fraxken merged commit ddf6882 into master Feb 12, 2023
@fraxken
Copy link
Member

fraxken commented Feb 12, 2023

@all-contributors please add @Kawacrepe for code

@allcontributors
Copy link
Contributor

@fraxken

I've put up a pull request to add @Kawacrepe! 🎉

@fraxken fraxken deleted the refacto--authors branch February 12, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants