-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @nodesecure/authors #62
Conversation
We may want to create a different issue about the TODO I put in the code. It consist in adding |
This line should be updated: https://github.com/NodeSecure/scanner/blob/master/src/depWalker.js#L326 |
@fraxken What do you think about this kind of payload ? {
warnings: {
globals: globalsWarning,
flaggedAuthors: xx.filter((el) => el.flagged === true))
},
authors,
} It may be future-proof (I'm thinking about nodesecure/rc atm) |
@Kawacrepe do we really need to touch the global Then for me it's the responsability of tools to filter flagged authors (like in Scanner / UI / CI ..). |
Oh okay, looks like I didn't understood one of your messages in the discord channel |
96bafcd
to
25b795a
Compare
f18d2ee
to
1391c8a
Compare
@all-contributors please add @Kawacrepe for code |
I've put up a pull request to add @Kawacrepe! 🎉 |
Related to NodeSecure/authors#10
Also: