Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tests to pass on node >= 18 #59

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

PierreDemailly
Copy link
Member

This PR fixes 3 things:

  • fix 1 vulnerability bumping undici from 5.5.1 to 5.8.0 (npm audit fix)
  • fix useless escaped character in the isGitDependency regex (linter was KO)
  • remove node:test as there is now the Test runner, also added in builtins library so tests was down on Node >= 18

Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraxken fraxken merged commit 538f94c into NodeSecure:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants