Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SAST warnings for semver #139

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Implement SAST warnings for semver #139

merged 6 commits into from
Aug 17, 2023

Conversation

fabnguess
Copy link
Contributor

This PR aims to solve the issue #91
close #91

PierreDemailly
PierreDemailly requested changes Jun 6, 2023
View reviewed changes
src/utils/semver.js Outdated Show resolved Hide resolved
test/utils/semver.spec.js Outdated Show resolved Hide resolved
test/utils/semver.spec.js Outdated Show resolved Hide resolved
src/utils/semver.js Outdated Show resolved Hide resolved
src/utils/semver.js Outdated Show resolved Hide resolved
PierreDemailly
PierreDemailly reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add the needed tests and we are fine 👍

src/tarball.js Outdated Show resolved Hide resolved
src/tarball.js Outdated Show resolved Hide resolved
PierreDemailly
PierreDemailly reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to test the warning to be added, you can get inspired from scanJavascriptFile.spec.js, you'll need to create a fixture with a package.json that have the wrong version

src/tarball.js Outdated Show resolved Hide resolved
src/tarball.js Outdated Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Outdated Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Outdated Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Outdated Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Outdated Show resolved Hide resolved
test/tarball/verifySemVer.spec.js Outdated Show resolved Hide resolved
test/utils/semver.spec.js Outdated Show resolved Hide resolved
PierreDemailly
PierreDemailly approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good to me

@fabnguess fabnguess marked this pull request as ready for review August 14, 2023 15:56
fraxken
fraxken requested changes Aug 15, 2023
View reviewed changes
src/tarball.js Outdated Show resolved Hide resolved
src/utils/semver.js Outdated Show resolved Hide resolved
@fraxken fraxken merged commit e65c79d into master Aug 17, 2023
@fraxken fraxken deleted the sast_warnings_semver branch March 18, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraxken fraxken fraxken approved these changes

@PierreDemailly PierreDemailly Awaiting requested review from PierreDemailly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SAST warnings for SemVer 0.0.0
3 participants
@fabnguess @fraxken @PierreDemailly