Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gym detail #312

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Gym detail #312

wants to merge 4 commits into from

Conversation

sebast1219
Copy link

New gym detail implementation with the lastest API

ALTER TABLE forts ADD COLUMN name VARCHAR(255) AFTER id;
DELETE FROM fort_sightings;
DELETE FROM forts;

And run scripts/create_db.py

player_lng_degrees = self.location[1],
gym_lat_degrees=fort.latitude,
gym_lng_degrees=fort.longitude
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, is there some documentation on this method somewhere? I have been successfully calling:
request.gym_get_info(gym_id=fort.id)
Without the lat/long parameters and it was working fine. I'm not doubting you it means I was probably doing it wrong, but is there some documentation I can see where you see the way to do this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed the only reliable way I found for it a.t.m.
the pogodev API page isn't up to date, otherwise that could be used.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good man thanks for that! :)

Copy link
Contributor

@j16sdiz j16sdiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@baskettcase
Copy link

baskettcase commented Jul 4, 2017

I believe this line needs to be removed in db.py

https://github.com/sebast1219/Monocle/blob/a6297441fd3b903a04e2bb78534d06314760c374/monocle/db.py#L621

Also occupied is how it is spelled, not ocuppied for time_occupied. Although that might be how Niantic is sending it to us? :)

RobTwoThree pushed a commit to RobTwoThree/Monocle that referenced this pull request Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants