Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass folder path to initialize Tensorboard object #86

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Conversation

melihyilmaz
Copy link
Collaborator

Changed tb_summarywriter from torch.utils.tensorboard.SummaryWriter to str because we used to initialize the object in config.py but can't do this in config.yaml. Initialization now happens inside Spec2Pep if a folder path is passed.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #86 (09fe6ec) into main (38af61a) will increase coverage by 12.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            main      #86       +/-   ##
==========================================
+ Coverage   1.43%   14.31%   +12.87%     
==========================================
  Files          9        9               
  Lines        556      559        +3     
==========================================
+ Hits           8       80       +72     
+ Misses       548      479       -69     
Impacted Files Coverage Δ
casanovo/denovo/model.py 36.69% <100.00%> (+36.69%) ⬆️
casanovo/denovo/evaluate.py 15.87% <0.00%> (+15.87%) ⬆️
casanovo/data/ms_io.py 21.15% <0.00%> (+21.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@wfondrie wfondrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to add a unit test 😉.

@wfondrie
Copy link
Collaborator

Feel free to merge when ready! 🎉

Also, please make sure to use "Squash and Merge"

@melihyilmaz melihyilmaz merged commit a5c05b8 into main Oct 26, 2022
@bittremieux bittremieux deleted the tensorboard_fix branch November 1, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants