-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Log Entry to Config File Bug #406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #406 +/- ##
==========================================
- Coverage 94.61% 94.56% -0.05%
==========================================
Files 14 14
Lines 1282 1289 +7
==========================================
+ Hits 1213 1219 +6
- Misses 69 70 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some considerations.
As you mentioned on Slack, I think it would also be good to add an integration test that checks whether the produced config file is actually compatible (i.e. you can run Casanovo with it).
Sounds good, I added additional test cases for the |
Fixed a bug that would write the log entries to the config file instead of the log file when running the
configure
command.