Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytorch lightning requirement #385

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Conversation

justin-a-sanders
Copy link

ModelCheckpoint only added the enable_version_counter parameter in version 2.1

bittremieux and others added 5 commits August 2, 2024 11:52
* bug report template

* punctuation, hardware description item

* Restrict NumPy to pre-2.0 (#344)

* Restrict NumPy to pre-2.0

* Update changelog

* Update paper reference (#361)

---------

Co-authored-by: Lilferrit <[email protected]>
* Update docs with model weights

* Generate new screengrabs with rich-codex

* Fix version and paper link

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (e6321a7) to head (27660fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          12       12           
  Lines         929      929           
=======================================
  Hits          834      834           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bittremieux bittremieux changed the base branch from main to dev October 1, 2024 09:53
Copy link
Collaborator

@bittremieux bittremieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter was introduced on dev, so can you rebase to there and fix the conflicts?

@justin-a-sanders justin-a-sanders merged commit 2d6e47b into dev Oct 29, 2024
@justin-a-sanders justin-a-sanders deleted the lightning_version_fix branch October 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants