tests: enable clippy::get_unwrap
lint
#87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through our test runner code, I noticed I had written code that follows this pattern -
But the second line can use
&h["foo"]
for equivalent behavior, clearer code, and a more informative error message if that key unexpectedly doesn't exist. I've already changed our code to use this clearer style, but I was like, wait why didn't Clippy warn about this?Turns out the answer is, there is such Clippy lint, but it's allow-by-default.
This PR makes
.get(...).unwrap()
a Clippy warning, i.e. it's fine in dev (e.g. temporarily using.unwrap()
where error handling will be added later) but we don't want code like this in production.