-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: support testing with Neovim #84
Conversation
Fixes handling of non-highlighted (cleared) trailing whitespace. Also restores compatibility with the upcoming Neovim 0.10.
@NoahTheDuke Sorry, forgot to mention that the reason for requesting your review before merge was not just the question about |
Hi @NoahTheDuke might you be able to review these Rust code changes soon? Would be good to get this merged before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left two comments, otherwise it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds
TEST_VIM
env var setting, which can be set to point to the Vim or Neovim executable to test with. If the specified executable'sfile_stem
contains "nvim", the test runner will treat it as Neovim. Otherwise, the test runner will treat it as Vim. If this env var is not set, runvim
same as before.To avoid Neovim creating
.local/state/nvim
in the repo, not sure whether is better to use a tempdir for$XDG_STATE_HOME
, as this patch does now, or to instead setNVIM_LOG_FILE
to something like/dev/null
?Not seeing any measurable performance regression in testing with Vim.
Closes #80
Edit: Also added fix for #86 per #86 (comment)