Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #79

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update CONTRIBUTING.md #79

merged 2 commits into from
Apr 3, 2024

Conversation

laniakea64
Copy link
Collaborator

  • Ask for rationale for PRs
  • Add documentation that gives some idea about rationales
  • Don't imply that we always or typically manually apply PRs, since most recent PRs have been merged in ways that they show as merged
  • Explicitly document that most test cases are designed to be valid and runnable as noted in Add info for contributors #77

Tag #75

@NoahTheDuke
Copy link
Owner

Yeah I moved on from manually merging PRs, wasn't worth the effort. Go for it.

@laniakea64 laniakea64 merged commit 4f6eea3 into main Apr 3, 2024
1 check passed
@laniakea64 laniakea64 deleted the contributing-doc branch April 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laniakea64 @NoahTheDuke