Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve justfile extension detection #73

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

eshepelyuk
Copy link
Contributor

No description provided.

@eshepelyuk eshepelyuk changed the title fix: detect justfile extensions fix: improve justfile extension detection Feb 6, 2024
@NoahTheDuke
Copy link
Owner

Thank you!

@NoahTheDuke NoahTheDuke merged commit 0ba9ff4 into NoahTheDuke:main Feb 6, 2024
1 check passed
@laniakea64
Copy link
Collaborator

Good catch, thanks.

Since the rationale for this change was missing from both the commit message and the original comment, filling it in here:

This PR adds ftdetect support for User justfiles, where the justfile is named .user.justfile. The way .user.justfile is used in those examples doesn't require the file to specifically be placed at $HOME/.user.justfile: the file could be located elsewhere, or the filename stem might not be .user e.g. if someone doesn't want this file to be hidden. So we should support detection of any file with .justfile extension.

@eshepelyuk
Copy link
Contributor Author

eshepelyuk commented Feb 6, 2024

Good catch, thanks.

Since the rationale for this change was missing from both the commit message and the original comment, filling it in here:

This PR adds ftdetect support for User justfiles, where the justfile is named .user.justfile. The way .user.justfile is used in those examples doesn't require the file to specifically be placed at $HOME/.user.justfile: the file could be located elsewhere, or the filename stem might not be .user e.g. if someone doesn't want this file to be hidden. So we should support detection of any file with .justfile extension.

this explanation is completely wrong.

the PR adds support for detection of files named like my.justfile, one.justfile etc.
It has nothing to do with user justfiles (in fact i never heard about this before).

@laniakea64
Copy link
Collaborator

this explanation is completely wrong.

the PR adds support for detection of files named like my.justfile, one.justfile etc. It has nothing to do with user justfiles (in fact i never heard about this before).

Where in the Just documentation did I miss other usage of the *.justfile extension?

@laniakea64 laniakea64 mentioned this pull request Feb 8, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants