Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test runner #51

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Update test runner #51

merged 3 commits into from
Oct 13, 2023

Conversation

laniakea64
Copy link
Collaborator

Using the test runner is now feeling a little slower than I remembered from before. And timing it confirms this.

This pull request restores the test runner to its prior performance on my system and fixes other issues found during the process:

  • Change and update dependencies to fix security warnings found by cargo-audit. This one was a stretch of my current Rust/Cargo skill level, so @NoahTheDuke your review would be appreciated, thanks 🙂
  • Update to regex 1.9.x (other versions of regex newer than 1.7.1 were either not changing performance or making it slightly worse)
  • Update other Cargo deps

In case it's relevant to any details of these changes, I'm using Rust 1.72.1, ran into issues with 1.73 with other projects so am currently deferring getting newer Rust version until Rust 1.74 release.

@NoahTheDuke
Copy link
Owner

What was causing the slow-down? Otherwise, this looks good to me.

@laniakea64
Copy link
Collaborator Author

laniakea64 commented Oct 13, 2023

What was causing the slow-down?

Unfortunately I have no idea 🤷

Looking at Rust release dates, maybe I'm comparing to before upgrading Rust to 1.72.x? Edit: it's not related to Rust version change. Was able to find the actual cause, see next comment.

Otherwise, this looks good to me.

Great 👍 Thanks for reviewing, will merge later today.

@laniakea64 laniakea64 merged commit 3038ffa into main Oct 13, 2023
1 check passed
@laniakea64 laniakea64 deleted the test-runner-update branch October 13, 2023 17:32
@laniakea64
Copy link
Collaborator Author

What was causing the slow-down?

Actually I figured it out:

In the interim, that Xubuntu 22.04 system's kernel was updated from 5.15.x to 6.2.x. Going back to latest 5.15.x kernel and previous test runner (keeping Rust 1.72.1) restores the performance I remember.

Can confirm that the changes in this PR speed up the test runner under kernel 5.15.x also 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants