Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): run tests on CentOS 7 #494

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(CI): run tests on CentOS 7 #494

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbe4b82
chore(CI): run tests on CentOS 7
mayeut Apr 29, 2023
55dc67f
fix(test): use `-fPIC` for many_syms_main_CFLAGS
mayeut Apr 29, 2023
8b24cc9
chore(CI): run tests on AlmaLinux 8
mayeut Apr 29, 2023
52b6770
chore(CI): run tests on Ubuntu 18.04
mayeut Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,28 @@ jobs:
mkdir build && cd build
../configure --with-asan --with-ubsan
make -j$(nproc) check
centos7:
strategy:
fail-fast: false
matrix:
platform: ["x86_64", "i686", "ppc64le", "aarch64", "s390x"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up QEMU
if: matrix.platform != 'x86_64'
uses: docker/setup-qemu-action@v2
- run: |
cat <<EOF > build.sh
set -e
set -x
c++ --version
ld --version
autoconf --version
./bootstrap.sh
mkdir build && cd build
../configure
make -j$(nproc) check || (cat tests/test-suite.log; exit 1)
EOF

docker run -v $(pwd):/gha quay.io/pypa/manylinux2014_${{ matrix.platform }}:latest sh -ec "cd /gha && sh ./build.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would we need to upgrade to next year when centos 7 is EOL? https://wiki.centos.org/About/Product

Copy link
Contributor Author

@mayeut mayeut Apr 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either ubuntu 18.04 or AlmaLinux 8 (/manylinux_2_28 which avoid installing a bunch of packages).
I could try to add it now to just be able to drop centos 7.

2 changes: 1 addition & 1 deletion tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ many_syms_main_SOURCES = many-syms-main.c
many_syms_main_LDFLAGS = $(LDFLAGS_local)
many_syms_main_LDADD = -lmany-syms $(AM_LDADD)
many_syms_main_DEPENDENCIES = libmany-syms.so
many_syms_main_CFLAGS = -pie
many_syms_main_CFLAGS = -fPIC -pie
libmany_syms_so_SOURCES = many-syms.c
libmany_syms_so_LDFLAGS = $(LDFLAGS_sharedlib)

Expand Down