Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake: 0.9.9 -> 0.10.2 #9964

Closed
wants to merge 1 commit into from
Closed

handbrake: 0.9.9 -> 0.10.2 #9964

wants to merge 1 commit into from

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Sep 20, 2015

The changelog is quite extensive, for more information please find the
changes documented here:
https://github.com/HandBrake/HandBrake/blob/master/NEWS

Built and run successfully on local.

The changelog is quite extensive, for more information please find the
changes documented here:
https://github.com/HandBrake/HandBrake/blob/master/NEWS

Built and run successfully on local.
@devhell
Copy link
Contributor Author

devhell commented Sep 20, 2015

/cc @wmertens

@wmertens
Copy link
Contributor

Eh, shouldn't the checksum be updated at least?

@devhell
Copy link
Contributor Author

devhell commented Sep 20, 2015

Duh.

@devhell devhell closed this Sep 20, 2015
@devhell
Copy link
Contributor Author

devhell commented Sep 20, 2015

@wmertens I'll leave this one alone, there have been obvious changes in regards to the patch, and I have no idea what the policy here is.

@wmertens
Copy link
Contributor

Well the problem is that handbrake basically ships with its own build system and in order to fix statefulness, reduce duplication and build time I split out their patches and made it build with the relevant Nix packages.

This is a bit of work but the other packages in NixPkgs benefit from it.

Alternative is to make a wrapper build that requires all the sources Handbrake wants, puts them together in a build directory and then runs the Handbrake builder. Less admin work, more resource wastage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants