Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdns_minimal
must be placed beforeresolve
in nsswitch.conf. This was broken by #86940 or #87016, when the config was split up into multiple modules and the ordering was lost. This PR usesmkOrder
to restore the correct ordering.This PR ends up placing
mymachines
betweenmdns_minimal
andresolve
, but I believe this is fine. My understanding of the problem is thatresolve
responds to all hostnames, so.local
domains currently never make it tomdns_minimal
. On the other hand,mdns_minimal
only responds to.local
domains and all other are passed on to the next module. So as long as a systemd container doesn't have a.local
domain there shouldn't be a problem.Fixes #98050.
cc @flokli
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)