-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libbitcoin 1.0.10 #964
Conversation
autoreconf -i | ||
''; | ||
|
||
configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you would make those paths a parameter to the function, so it can be overriden in nixpkgs config or nixos config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will just remove them, they don't seem to matter, i don't know why they
were set in arch linux pkgbuild i used for reference.
On Sep 14, 2013 5:59 PM, "Domen Kožar" [email protected] wrote:
In pkgs/development/libraries/libbitcoin/default.nix:
+stdenv.mkDerivation {
- name = "libbitcoin-${version}";
- src = fetchurl {
- url = "http://libbitcoin.dyne.org/download/libbitcoin-1.0.10.tar.bz2";
- sha256 = "2b8b5e6772b0872cc186b08a3e0ebdaaf4c9f06fb7192ba9414f6e67f083c06d";
- };
- buildInputs = [ pkgconfig automake autoconf libtool curl leveldb protobuf boost ];
- preConfigure =
- ''
autoreconf -i
- '';
- configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb";
Normally you would make those paths a parameter to the function, so it can
be overriden in nixpkgs config or nixos config.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/964/files#r6364116
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let me just test this, i have some problems with running examples, ok?
On Sep 18, 2013 8:52 PM, "Domen Kožar" [email protected] wrote:
In pkgs/development/libraries/libbitcoin/default.nix:
+stdenv.mkDerivation {
- name = "libbitcoin-${version}";
- src = fetchurl {
- url = "http://libbitcoin.dyne.org/download/libbitcoin-1.0.10.tar.bz2";
- sha256 = "2b8b5e6772b0872cc186b08a3e0ebdaaf4c9f06fb7192ba9414f6e67f083c06d";
- };
- buildInputs = [ pkgconfig automake autoconf libtool curl leveldb protobuf boost ];
- preConfigure =
- ''
autoreconf -i
- '';
- configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb";
ping?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/964/files#r6442865
.
@offlinehacker, do you still want to have this expression merged? |
Ok it seems to work fine, it's just a bit slow, still the best bitcoin lib that you can use in python language(throught C module). It does not include some libs(like curl) in pkg-config(.pc) and i don't know how to fix this(now you have to add those in your environment, i have tried propagatedBuildInputs, no success). I would be very happy if anybody has any knowledge how to fix that? |
It executes the tools found through PATH? |
No, i don't know how to include curl with libbitcoin, now you have have On Thu, Oct 3, 2013 at 8:35 PM, Vladimír Čunát [email protected]:
|
If it's worth the bother, it would be probably the best way to patch the code that does the finding (and hardcode the path there on build-time). I see no easier way. |
The above holds if it uses the commands (which I suppose). If it dlopened the library, then it should be enough to patchelf the RPATH. |
Looks like pkg-config has a setup hook that exports PKG_CONFIG_PATH in builds and it's of course not exported(if you don't do it yourself) in buildEnv and this is really not a problem. |
Wouldn't it be better to merge this package only after it works reliably? |
Yes i changed my mind and i agree. It turns out @spesmilo on github develops some awesome bitcoin tools(rpc worker and low level command line tool for bitcoin) that do not depend on release version but the one from git. |
Also checkout https://github.com/conformal/btcd |
Cool! Still lol, who would want to reimplement ugly rpc api of bitcoin wallet. |
So this one can be closed, since it's not complete? |
Please leave it open, i have some uncompleted work, but i'm really close, On Thu, Oct 31, 2013 at 3:32 PM, Domen Kožar [email protected]:
|
@offlinehacker update? |
@offlinehacker Please feel free to reopen if you are still working on this. |
No description provided.