Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libbitcoin 1.0.10 #964

Closed
wants to merge 1 commit into from
Closed

Conversation

offlinehacker
Copy link
Contributor

No description provided.

autoreconf -i
'';

configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you would make those paths a parameter to the function, so it can be overriden in nixpkgs config or nixos config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just remove them, they don't seem to matter, i don't know why they
were set in arch linux pkgbuild i used for reference.
On Sep 14, 2013 5:59 PM, "Domen Kožar" [email protected] wrote:

In pkgs/development/libraries/libbitcoin/default.nix:

+stdenv.mkDerivation {

  • name = "libbitcoin-${version}";
  • buildInputs = [ pkgconfig automake autoconf libtool curl leveldb protobuf boost ];
  • preConfigure =
  • ''
  •  autoreconf -i
    
  • '';
  • configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb";

Normally you would make those paths a parameter to the function, so it can
be overriden in nixpkgs config or nixos config.


Reply to this email directly or view it on GitHubhttps://github.com//pull/964/files#r6364116
.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me just test this, i have some problems with running examples, ok?
On Sep 18, 2013 8:52 PM, "Domen Kožar" [email protected] wrote:

In pkgs/development/libraries/libbitcoin/default.nix:

+stdenv.mkDerivation {

  • name = "libbitcoin-${version}";
  • buildInputs = [ pkgconfig automake autoconf libtool curl leveldb protobuf boost ];
  • preConfigure =
  • ''
  •  autoreconf -i
    
  • '';
  • configureFlags = "--localstatedir=/var --sharedstatedir=/var --sysconfdir=/etc --enable-leveldb";

ping?


Reply to this email directly or view it on GitHubhttps://github.com//pull/964/files#r6442865
.

@peti
Copy link
Member

peti commented Oct 3, 2013

@offlinehacker, do you still want to have this expression merged?

@offlinehacker
Copy link
Contributor Author

Ok it seems to work fine, it's just a bit slow, still the best bitcoin lib that you can use in python language(throught C module). It does not include some libs(like curl) in pkg-config(.pc) and i don't know how to fix this(now you have to add those in your environment, i have tried propagatedBuildInputs, no success). I would be very happy if anybody has any knowledge how to fix that?

@vcunat
Copy link
Member

vcunat commented Oct 3, 2013

It executes the tools found through PATH?

@offlinehacker
Copy link
Contributor Author

No, i don't know how to include curl with libbitcoin, now you have have
curl in environment(and not only libbitcoin) for libbitcoin programs to
compile or it does not find curl. Even if i add curl in
propagatedBuildInputs the problem remains.

On Thu, Oct 3, 2013 at 8:35 PM, Vladimír Čunát [email protected]:

It executes the tools found through PATH?


Reply to this email directly or view it on GitHubhttps://github.com//pull/964#issuecomment-25646255
.

@vcunat
Copy link
Member

vcunat commented Oct 4, 2013

If it's worth the bother, it would be probably the best way to patch the code that does the finding (and hardcode the path there on build-time). I see no easier way.

@vcunat
Copy link
Member

vcunat commented Oct 4, 2013

The above holds if it uses the commands (which I suppose). If it dlopened the library, then it should be enough to patchelf the RPATH.

@offlinehacker
Copy link
Contributor Author

Looks like pkg-config has a setup hook that exports PKG_CONFIG_PATH in builds and it's of course not exported(if you don't do it yourself) in buildEnv and this is really not a problem.
Just merge this, i might use version from github which has some usefull additional functions, but we can update later.

@peti
Copy link
Member

peti commented Oct 6, 2013

Wouldn't it be better to merge this package only after it works reliably?

@offlinehacker
Copy link
Contributor Author

Yes i changed my mind and i agree. It turns out @spesmilo on github develops some awesome bitcoin tools(rpc worker and low level command line tool for bitcoin) that do not depend on release version but the one from git.
I will package those two and we can merge then :) Besides that, this one works reliably.

@domenkozar
Copy link
Member

Also checkout https://github.com/conformal/btcd

@offlinehacker
Copy link
Contributor Author

Cool! Still lol, who would want to reimplement ugly rpc api of bitcoin wallet.

@domenkozar
Copy link
Member

So this one can be closed, since it's not complete?

@offlinehacker
Copy link
Contributor Author

Please leave it open, i have some uncompleted work, but i'm really close,
not just libbitcoin, but also related awesome tools for bitcoin developers.

On Thu, Oct 31, 2013 at 3:32 PM, Domen Kožar [email protected]:

So this one can be closed, since it's not complete?


Reply to this email directly or view it on GitHubhttps://github.com//pull/964#issuecomment-27490309
.

@domenkozar
Copy link
Member

@offlinehacker update?

@shlevy
Copy link
Member

shlevy commented Mar 14, 2014

@offlinehacker Please feel free to reopen if you are still working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants